Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Emission of Pre-Block Events #611

Open
wants to merge 2 commits into
base: release-pio/v0.50.x
Choose a base branch
from

Conversation

nullpointer0x00
Copy link

@nullpointer0x00 nullpointer0x00 commented Jul 29, 2024

Description

This PR addresses an issue in the cosmos-sdk where pre-block events were being ignored during the upgrade process. These events are crucial for state changes, particularly for Provenance's use case. For example, the scope navigation updates introduced in v1.19.0 were not emitted because of this issue.

The changes in this PR ensure that pre-block events are properly emitted during upgrades, thereby preserving important state transitions such as those required for Provenance's scope navigation updates.

This fix is non-breaking and can be released as an optional point release.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@nullpointer0x00 nullpointer0x00 self-assigned this Aug 28, 2024
@nullpointer0x00 nullpointer0x00 changed the title Capture preblocker events Fix Emission of Pre-Block Events During Upgrade Process Aug 28, 2024
@nullpointer0x00 nullpointer0x00 changed the title Fix Emission of Pre-Block Events During Upgrade Process Fix Emission of Pre-Block Events Aug 28, 2024
@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review August 28, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant